Create REAEME.md #24
Closed
Create REAEME.md #24
+49
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: SEONG PIL JU <[email protected]>
aiclaudev
requested review from
jopopcorn,
JuSeongPil and
sujin9
as code owners
jopopcorn
approved these changes
Aug 28, 2021
README.md
Outdated
Comment on lines
5
to
6
| This is a check-in application that identifies visitors, especially effective during the COVID-19. | ||
| This application stores below informations in database |
There was a problem hiding this comment.
I'd like to apply the enter one more time.
Suggested change
| This is a check-in application that identifies visitors, especially effective during the COVID-19. | |
| This application stores below informations in database | |
| This is a check-in application that identifies visitors, especially effective during the COVID-19. | |
| This application stores below informations in database. |
README.md
Outdated
Comment on lines
42
to
44
| It is based on Euphony library. | ||
| Official Facebook Page : https://www.facebook.com/euphonyproject | ||
| Official Library Site : https://dev.jbear.co/euphony |
There was a problem hiding this comment.
Please apply Enter to this part as well.
Suggested change
| It is based on Euphony library. | |
| Official Facebook Page : https://www.facebook.com/euphonyproject | |
| Official Library Site : https://dev.jbear.co/euphony | |
| It is based on Euphony library. | |
| Official Facebook Page : https://www.facebook.com/euphonyproject | |
| Official Library Site : https://dev.jbear.co/euphony |
README.md
Outdated
Comment on lines
37
to
38
| To report a specific problem or feature request, [please open a new issue](https://github.com/euphony-io/soundless-check-in/issues/new/choose). | ||
| Your participation drives the development of the application! |
There was a problem hiding this comment.
Please apply Enter to this part as well!
Suggested change
| To report a specific problem or feature request, [please open a new issue](https://github.com/euphony-io/soundless-check-in/issues/new/choose). | |
| Your participation drives the development of the application! | |
| To report a specific problem or feature request, [please open a new issue](https://github.com/euphony-io/soundless-check-in/issues/new/choose). | |
| Your participation drives the development of the application! |
Co-Authored-By: SEONG PIL JU <[email protected]>
Add new line below 'This application stores below informations in database' sentence Co-Authored-By: SEONG PIL JU <[email protected]>
|
@jopopcorn |
|
Great! Thanks your efforts 😄 |
sujin9
approved these changes
Aug 29, 2021
It's so great idea !! |
|
I would appreciate it if you could add a license when modifying README! Licensesoundless-check-in is licensed under the Apache 2.0 license. See the LICENSE file for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: SEONG PIL JU [email protected]
What does this PR do? Please write it down in detail.
What was the previous problem ?
There is no README.md in euphony-io/soundless-check-in.
How did you solve it?
Through discussing, Add Reason for making this application, Run the app, Report Issues, Library category.
Link to the related issue
Issue #2
Is there anything you have tried to improve but failed?
I wanted to add 'What is next' category, but i don't know what to write in this category.